Remove unused dependency from sqlite example #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Reese <[email protected]>
itowlson
requested changes
Aug 3, 2025
Contributor
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
I may be misreading here and if so I'm happy to approve, but right now I'm a bit concerned that this might not be right, sorry.
| SQLite functions are available in the `spin_sdk::sqlite` module. The function names match the operations above. For example: | ||
|
|
||
| ```rust | ||
| use anyhow::Result; |
Contributor
There was a problem hiding this comment.
Isn't this used on line 69 (the return value of handle_request? I might be misunderstanding.
Contributor
Author
|
Oh, wow. Rust analyzer moved it inline when I was hacking on the example. Late Saturday night PR fail. Sorry for the noise Ivan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snuck in a few whitespaces also