Skip to content

Conversation

@vdice
Copy link
Contributor

@vdice vdice commented Mar 27, 2025

@vdice vdice mentioned this pull request Mar 27, 2025
3 tasks
@github-actions
Copy link

🚀 preview deployed successfully to Fermyon Cloud and available at https://spin-docs-pr-36-p2uhomrv.fermyon.app

@vdice vdice marked this pull request as ready for review March 27, 2025 21:11
@vdice vdice force-pushed the ci/deploy-site branch 2 times, most recently from f79e556 to 914309e Compare March 27, 2025 21:35
Signed-off-by: Vaughn Dice <[email protected]>
@vdice vdice requested a review from itowlson March 27, 2025 21:49
uses: actions/upload-artifact@v4
with:
name: app
# These are all of the paths referenced in spin.toml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit concerned about the maintenance implications here but it's not a blocker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am as well... I took inspiration from another website/app (Finicky Whiskers) as I liked the flow of "build, save artifacts, deploy artifacts" but this site has many more files to track. Maybe all we need is a better pattern matching approach... eg something as simple as a "not node_modules" negation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#44

@vdice vdice merged commit 29c50af into main Mar 27, 2025
3 checks passed
@vdice vdice deleted the ci/deploy-site branch March 27, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants