Skip to content

Conversation

@kate-goldenring
Copy link
Contributor

The Kubernetes document is redundant to the linking we do in deploying.md. In general, when we remove a document, should we remove it from v1, v2 and v3? I just removed from v3 here

@kate-goldenring kate-goldenring requested a review from itowlson April 1, 2025 17:03
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we've removed the Kubernetes entry from the TOC, so there's no point keeping the page.

cc @flynnduism to confirm that this was intentional

@flynnduism
Copy link
Contributor

The Deployment Options page and SpinKube menu entries make the Kubernetes path pretty clear, so IMO removing this is good.

We should include a redirect for the page being removed, so any prior /kubernetes paths go to the /deploy-options page

@kate-goldenring kate-goldenring force-pushed the remove-kubernetes-doc branch from c8e4b69 to f1f0b56 Compare April 1, 2025 21:25
@kate-goldenring
Copy link
Contributor Author

@flynnduism how do i add a redirect? Also should we delete the v1 and v2 doc as well?

@michelleN michelleN added this to the initial-bug-bash milestone Apr 1, 2025
@itowlson
Copy link
Contributor

itowlson commented Apr 7, 2025

@itowlson
Copy link
Contributor

@vdice Any guidance on redirects so we can close out the remaining request on this PR and get it in? Thanks!

@vdice
Copy link
Contributor

vdice commented Apr 29, 2025

@kate-goldenring adding the following to the spin manifest should work for these purposes:

[[trigger.http]]
id = "trigger-redirect-kubernetes"
component = "redirect-kubernetes"
route = "/kubernetes"

[component.redirect-kubernetes]
source = "modules/redirect.wasm"
environment = { DESTINATION = "/deploying", STATUSCODE = "301" }

(It looks like we already have the redirect module in the modules directory - must've been from the initial docs migration.)

should we remove it from v1, v2 and v3?

I'd vote yes. Potential inbound redirects from the developer.fermyon.com appear to all be unversioned, so I believe we're good there.

@kate-goldenring
Copy link
Contributor Author

Thanks for bumping this @itowlson and adding the suggestion @vdice. I've updated it and ran locally to confirm the redirect works

@itowlson itowlson merged commit 1d6b3d0 into spinframework:main Apr 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants