-
Notifications
You must be signed in to change notification settings - Fork 12
Remove redundant Kubernetes doc #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant Kubernetes doc #71
Conversation
itowlson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we've removed the Kubernetes entry from the TOC, so there's no point keeping the page.
cc @flynnduism to confirm that this was intentional
|
The Deployment Options page and SpinKube menu entries make the Kubernetes path pretty clear, so IMO removing this is good. We should include a redirect for the page being removed, so any prior /kubernetes paths go to the /deploy-options page |
c8e4b69 to
f1f0b56
Compare
|
@flynnduism how do i add a redirect? Also should we delete the v1 and v2 doc as well? |
|
@kate-goldenring we used to do redirects like https://github.com/fermyon/developer/blob/cba4bb3594c04869d7e18d6a54e64ec782dbbc33/spin.toml#L90 and https://github.com/fermyon/developer/blob/cba4bb3594c04869d7e18d6a54e64ec782dbbc33/spin.toml#L266 - I am not sure if there is a New And Improved way though. |
|
@vdice Any guidance on redirects so we can close out the remaining request on this PR and get it in? Thanks! |
|
@kate-goldenring adding the following to the spin manifest should work for these purposes: (It looks like we already have the redirect module in the
I'd vote yes. Potential inbound redirects from the developer.fermyon.com appear to all be unversioned, so I believe we're good there. |
Signed-off-by: Kate Goldenring <[email protected]>
f1f0b56 to
b105b4b
Compare
The Kubernetes document is redundant to the linking we do in
deploying.md. In general, when we remove a document, should we remove it from v1, v2 and v3? I just removed from v3 here