Add support for wasip2 variables #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajatjindal
force-pushed
the
spin-w2-variables
branch
from
9ad1692 to
a32f9a3
Compare
adamreese
reviewed
Apr 11, 2025
| if resp.Body == nil { | ||
| t.Fatal("body is nil") | ||
| } | ||
| t.Log(resp.Status) |
Contributor
There was a problem hiding this comment.
Is this for debugging only?
Member
Author
There was a problem hiding this comment.
yeah, i guess we can keep it there? happy to remove if you insist.
rajatjindal
force-pushed
the
spin-w2-variables
branch
from
a32f9a3 to
5896256
Compare
Signed-off-by: Rajat Jindal <[email protected]>
rajatjindal
force-pushed
the
spin-w2-variables
branch
from
5896256 to
72c0f22
Compare
Member
Author
|
Hi @adamreese i think this branch is ready for review. thank you. (I have started work on the changes for support to redis). |
adamreese
approved these changes
Apr 22, 2025
Member
Author
|
❤️ thanks Adam. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
built on top of #18