upgrade knitwit and add caching to build script #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthik2804
force-pushed
the
improve_build
branch
2 times, most recently
from
a2f1c47 to
387a9a6
Compare
Contributor
ThorstenHans
left a comment
ThorstenHans
left a comment
There was a problem hiding this comment.
Raised two questions as part of my review
| const sourceChecksum = await calculateChecksum(src); | ||
| const existingChecksum = await getExistingChecksum(inputChecksumPath); | ||
|
|
||
| if ((existingChecksum === sourceChecksum) && fileExists(outputPath)) { |
Contributor
There was a problem hiding this comment.
IMO we should also create a checksum for package-lock.json. Shouldn't we? User could update dependencies or dev-dependencies that could affect the build.
Collaborator
Author
There was a problem hiding this comment.
That will have an impact on the bundle generated by webpack which is what would be the input to this build script. We still end up running webpack everytime.
Signed-off-by: karthik2804 <[email protected]>
karthik2804
force-pushed
the
improve_build
branch
from
387a9a6 to
15dd1f9
Compare
radu-matei
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can upgrade the Componentize-js once there is a new release. This PR will allow us to create a new release which can then be used to restructure templates.
This PR also adds caching to avoid componentization during the build if not required.