Restructure templates #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: karthik2804 <[email protected]>
radu-matei
reviewed
Jan 20, 2025
| export async function handler(req, res) { | ||
| console.log(req); | ||
| let router = Router(); | ||
| router.get("*", (_, req, res) => { handleDefaultRoute(req, res) }) |
Member
There was a problem hiding this comment.
potential nit that you can ignore: instead of separate functions, lambdas here?
Collaborator
Author
There was a problem hiding this comment.
I have a slight preference in this case to use functions as it keeps the router structure easily readable when more are added.
tschneidereit
approved these changes
Jan 20, 2025
Collaborator
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
Looks good to me! I added a few suggestions, but nothing major
Signed-off-by: karthik2804 <[email protected]>
Collaborator
Author
|
@tschneidereit updated to be in line with the suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restructures the templates so that the default directory structure follows more javascript-ish structure and tucks away knitwit as the user should not have to deal with it usually. It also updates the default HTTP templates to now have a router with a catch-all 404 set up.