add action to automate publish releases to npm #334
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: karthik2804 <[email protected]>
karthik2804
requested review from
ThorstenHans,
radu-matei and
tschneidereit
Signed-off-by: karthik2804 <[email protected]>
Contributor
|
@karthik2804 see my comment in #324 about generating docs |
Collaborator
Author
|
@ThorstenHans I like the idea of releasing docs per release but would prefer not to roll that into this PR as that will involve us having to generate and commit docs or push it to a package. I am happy to tackle that as a follow-up. |
radu-matei
approved these changes
Feb 17, 2025
|
|
||
| # Determine if the tag is a release candidate or not | ||
| - name: Determine npm tag | ||
| id: npm_tag |
Member
There was a problem hiding this comment.
nit: why the ID for this job but not for anything else?
Collaborator
Author
There was a problem hiding this comment.
It can be safely removed.
Collaborator
Author
|
Closing this as we will need to work on a different action once we have v4 because each interface becomes modularized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds action that publishes package to npm when a tag starting with
vis pushed.