-
Notifications
You must be signed in to change notification settings - Fork 19
Fix build caching #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
karthik2804
merged 2 commits into
spinframework:main
from
karthik2804:fix_build_caching
Jul 21, 2025
Merged
Fix build caching #371
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,8 @@ import { componentize } from '@bytecodealliance/componentize-js'; | |
| import { version as componentizeVersion } from '@bytecodealliance/componentize-js'; | ||
| import { getPackagesWithWasiDeps, processWasiDeps } from './wasiDepsParser.js'; | ||
| import { | ||
| calculateChecksum, | ||
| calculateCheckSum, | ||
| calculateFileChecksum, | ||
| saveBuildData, | ||
| } from './utils.js'; | ||
| import { getCliArgs } from './cli.js'; | ||
|
|
@@ -23,15 +24,6 @@ async function main() { | |
| let outputPath = CliArgs.output; | ||
| let runtimeArgs = CliArgs.debug ? '--enable-script-debugging' : ''; | ||
|
|
||
| // Small optimization to skip componentization if the source file hasn't changed | ||
| if (!(await ShouldComponentize(src, outputPath, componentizeVersion, runtimeArgs))) { | ||
| console.log( | ||
| 'No changes detected in source file. Skipping componentization.', | ||
| ); | ||
| return; | ||
| } | ||
| console.log('Componentizing...'); | ||
|
|
||
| // generate wit world string | ||
| let wasiDeps = getPackagesWithWasiDeps(process.cwd(), new Set(), true); | ||
| let { witPaths, targetWorlds } = processWasiDeps(wasiDeps); | ||
|
|
@@ -63,6 +55,17 @@ async function main() { | |
| 'combined-wit:[email protected]', | ||
| ); | ||
|
|
||
| // Calcuilate the checksum of the inline wit | ||
| let inlineWitChecksum = await calculateCheckSum(inlineWit); | ||
| // Small optimization to skip componentization if the source file hasn't changed | ||
| if (!(await ShouldComponentize(src, outputPath, componentizeVersion, runtimeArgs, inlineWitChecksum))) { | ||
| console.log( | ||
| 'No changes detected in source file and target World. Skipping componentization.', | ||
| ); | ||
| return; | ||
| } | ||
| console.log('Componentizing...'); | ||
|
|
||
| const source = await readFile(src, 'utf8'); | ||
| const precompiledSource = precompile(source, src, true) as string; | ||
|
|
||
|
|
@@ -85,9 +88,10 @@ async function main() { | |
| // Save the checksum of the input file along with the componentize version | ||
| await saveBuildData( | ||
| getBuildDataPath(src), | ||
| await calculateChecksum(src), | ||
| await calculateFileChecksum(src), | ||
| componentizeVersion, | ||
| runtimeArgs, | ||
| inlineWitChecksum, | ||
| ); | ||
|
|
||
| console.log('Component successfully written.'); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.