add ability to generate chained sourcemap for precompiled sources #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karthik Ganeshram <[email protected]>
karthik2804
force-pushed
the
sourcemap_chaining
branch
from
46745c1 to
6ebf68f
Compare
Collaborator
Author
|
Converting to draft to fix up a couple of alignment issues. |
This commit fixes updating the sourcemap comment to point to the right file. It also updates the test to use esbuild instead of webpack as the sourcemaps generated by esbuild are friendlier without webpack speicif protocol representing files. As we move to esbuild, the existing webpack plugin is modified to suit esbuild as well. Signed-off-by: Karthik Ganeshram <[email protected]>
Collaborator
Author
|
The test has been updated to use esbuild and now the |
Signed-off-by: Karthik Ganeshram <[email protected]>
Collaborator
Author
|
@tschneidereit friendly bump for a review. Thanks! |
tschneidereit
approved these changes
Aug 13, 2025
Collaborator
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
Apologies for the delay!
karthik2804
force-pushed
the
sourcemap_chaining
branch
from
f9a5288 to
aae515c
Compare
Signed-off-by: Karthik Ganeshram <[email protected]>
karthik2804
force-pushed
the
sourcemap_chaining
branch
from
aae515c to
3222e92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the capability to the build tooling to chain the source map for the precompiled source with the input source map, allowing for better debugging.
In a follow-up PR, the plan is to move to build instead of webpack because the source maps generated by build are friendlier.
cc: @itowlson