fix: CI: Build apps on PRs #440
Conversation
shanaya-Gupta
requested review from
bacongobbler,
calebschoepp,
endocrimes and
michelleN
as code owners
There was a problem hiding this comment.
Thanks so much for the quick PR addressing the recent issue! I've noted a couple of items to revisit.
Also, regarding the DCO check, please check out the Contributing guide on what is needed: a DCO sign-off as well as GPG-signing your commits. Let me know if I can help here.
| push: | ||
| branches: | ||
| - main | ||
| pull_request: |
There was a problem hiding this comment.
Let's limit this workflow to PRs against the main branch specifically:
| pull_request: | |
| pull_request: | |
| branches: | |
| - main |
| # For pull requests, we only build the application to validate it. | ||
| - name: Build application on PR | ||
| if: github.event_name == 'pull_request' | ||
| uses: fermyon/actions/spin/build@v1 |
There was a problem hiding this comment.
Alas, there is no fermyon/actions/spin/build action currently offered by https://github.com/fermyon/actions -- or https://github.com/spinframework/actions, the current home for the actions.
For now, we'd have to utilize a run step to invoke the spin binary that was installed by the spin/setup action above:
- name: Run spin build
if: github.event_name == 'pull_request'
run: spin build -f apps/${{ matrix.app }}/spin.toml
2 participants
Fix for Issue #439
Issue: CI: Build apps on PRs
Changes:
.github/workflows/sample-apps.yamlPlease review carefully before merging.