change url for js2wasm from fermyon to spinframework #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajat Jindal <[email protected]>
Contributor
|
Perhaps we should instead move the js2wasm binaries back to the archive repo, since its express purpose is to keep the backward compatibility stuff and that is what js2wasm is at this point...? Not sure, just raising for discussion. |
Contributor
|
I agree with @itowlson that moving the js2wasm binaries back to the archive repo would be nicer so that it is just maintaining backward compatibility. |
Contributor
|
If we do not have any objections to moving those back to the archive repo, I will do it this week. |
Contributor
|
The plugin binaries have been moved back to releases in the old archival repo and should continue to function as expected. I will close this issue now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we added a placeholder repo for github.com/fermyon/spin-js-sdk, which breaks existing plugin release urls.
I discovered this issue while testing move of
actionsrepo rtospinframeworkorg: https://github.com/rajatjindal/spinframework-actions/actions/runs/14810087267/job/41583714412?pr=11