feat(verman): adding v0.1.2 #128
Conversation
There was a problem hiding this comment.
The latest file needs to be named just verman.json
There was a problem hiding this comment.
This file needs to be renamed to vermain0.1.1.json and contain the the v0.1.1 manifest. The latest version is always picked from just the package_name.json
There was a problem hiding this comment.
Lol no idea where I was getting 0.1.2. Thanks for catching that
There was a problem hiding this comment.
Oh, wait. The latest GH release for verman is 0.1.2. Do I need to include both 0.1.1 and 0.1.2? If I'm remembering correctly, there were issues with the 0.1.1 release.
There was a problem hiding this comment.
IIRC, it was 0.1.0 that had issues. But in any case, let us preserve history, as the registry already has 0.1.1 and 0.1.0 published. We should end up with a structure like
verman.jsonwith v0.1.2 manifest[email protected]with v0.1.1 manifest[email protected]with v0.1.0 manifest
Signed-off-by: Andrew Steurer <[email protected]>
There was a problem hiding this comment.
Not quire sure why 0.1.0 has changed? It should just be rename verman.json to [email protected] and then add the 0.1.2 manifest. Older versions shouldn't have to do anything.
There was a problem hiding this comment.
The change is just removing whitespace. Will that cause problems?
There was a problem hiding this comment.
I guess not. I dislike cluttering git history this way but in this case I should get over myself eh
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
Looks fine apart from the changes to the 0.1.0 file. Could you revert those please? Happy to approve and merge at that point.
3 participants
Please let me know if I forgot anything!