add Spin 3 support #114
Merged
add Spin 3 support #114
+4,203
−7,014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This adds support for fermyon:[email protected] worlds, while still using the 2.0.0 worlds by default. Apps may opt-in to using a 3.0.0 world by specifying e.g. `--world fermyon:spin/[email protected]` as part of their `componentize-py` command in their `spin.toml` file. This also updates to `componentize-py` v0.16.0 (which includes bytecodealliance/componentize-py#128, a feature required for compatibility with earlier SDK releases). Signed-off-by: Joel Dice <[email protected]>
|
99.9% of the changes here are in generated code and docs. The main things to note are the newly-added WIT files and the |
|
The PR looks great. Do we also want to add some wrapping code in the SDK for |
Yeah, but let's leave that for a separate PR. This one's big enough already. |
karthik2804
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for fermyon:[email protected] worlds, while still using the 2.0.0 worlds by default. Apps may opt-in to using a 3.0.0 world by specifying e.g.
--world fermyon:spin/[email protected]as part of theircomponentize-pycommand in theirspin.tomlfile.This also updates to
componentize-pyv0.16.0 (which includes bytecodealliance/componentize-py#128, a feature required for compatibility with earlier SDK releases).