update to latest Spin WIT files #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes (minimal, raw binding) support for `spin:[email protected]` and `spin:[email protected]`. Signed-off-by: Joel Dice <[email protected]>
This was referenced Aug 25, 2025
karthik2804
reviewed
Aug 26, 2025
|
|
||
|
|
||
| class SpinAll(Protocol): | ||
| class SpinSdkWit(Protocol): |
There was a problem hiding this comment.
Not sure why this changed. I assume it is due to an upstream change?
There was a problem hiding this comment.
Yeah, it's due to bytecodealliance/componentize-py#150, which changed how the --world-module option works. I don't think it matters in this case since the world had no direct function imports or exports (i.e. all the functions are inside interfaces), so the class is empty and useless. Renaming it shouldn't break any real-world code.
karthik2804
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes (minimal, raw binding) support for
spin:[email protected]andspin:[email protected].