WASI P3 echo server sample #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
reviewed
Nov 6, 2025
|
|
||
| // Use wit_bindgen::spawn to allow the async block to keep running | ||
| // after the handler returns. | ||
| spin_sdk::http_wasip3::wasip3::wit_bindgen::spawn(async move { |
Contributor
There was a problem hiding this comment.
Should we be exposing spawn from the SDK directly instead of requiring users to know the very long spin_sdk::http_wasip3::wasip3::wit_bindgen namespace?
Contributor
Author
There was a problem hiding this comment.
Excellent question - we may want to consider that for wit_future and wit_stream as well. I'd like to put that out of scope for this PR though if that's okay?
itowlson
force-pushed
the
wasip3-streaming-sample
branch
from
ccb60e3 to
4e8b417
Compare
fibonacci1729
approved these changes
Nov 6, 2025
Contributor
fibonacci1729
left a comment
fibonacci1729
left a comment
There was a problem hiding this comment.
This is awesome! So clean and simple. Agree with the comment about moving some more bits into a prelude but OOB for this one.
Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
wasip3-streaming-sample
branch
from
4e8b417 to
7301a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while to figure out the P3 streaming incantations, and I thought others might find them useful too.
Also, I thought someone might fall around laughing and go "no, you can do it way simpler than that you cabbage," which would be an even bigger win.