Revert "Switch to wit-bindgen 0.34" #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fibonacci1729
force-pushed
the
revert-44-wit-bindgen-0-34
branch
from
31d51f7 to
dc5de2b
Compare
itowlson
approved these changes
Nov 25, 2024
Contributor
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
All that search-and-replacing float to f and for naught
fibonacci1729
force-pushed
the
revert-44-wit-bindgen-0-34
branch
from
dc5de2b to
8e33f6c
Compare
Signed-off-by: Brian H <[email protected]>
fibonacci1729
force-pushed
the
revert-44-wit-bindgen-0-34
branch
from
8e33f6c to
9b7dd29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A decision was made in the spin-maintainers meeting to revert these changes given the driving use-case has stalled and there is otherwise no reason to update wit-bindgen at the moment which would complicate cutting a new release (which would require a minor version bump) and potentially poses other complexities when mixing libs using various wit-bindgen versions.
Reverts #44