feat(loader/cache): add data dir fallback if wasm layer not found #1941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaughn Dice <[email protected]>
lann
approved these changes
Oct 25, 2023
Collaborator
lann
left a comment
lann
left a comment
There was a problem hiding this comment.
We could probably just merge the wasm and data dirs together anyway...
Contributor
Author
Good point... we should be able to do that in a refactor post-2.0 if we don't get to it beforehand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-emptive 'futureproofing' in anticipation of the wasm layer media type changing in the future (see #1882 (comment)).
This change is intended for the forthcoming 2.0 release. With this logic in place, 2.0 clients should continue to be able to pull Spin apps published by a future version of Spin with the wasm layer media type changed.