Skip to content

Conversation

@tyler-harpool
Copy link

Purpose of this PR is to add datetime and timestamp support.

Purpose of this PR is to add datetime and timestamp support. 

Signed-off-by: tyler-harpool <[email protected]>
Copy link
Collaborator

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Adding this will constitute a breaking change so we'll need to make sure we do accept this at the right time. We're figuring out what changes to land in Spin 3.0 so this will definitely be a good candidate for discussion. In the meantime, we appreciate your patience while the discussion happens.

@rylev rylev added the spin-3.0 label Sep 25, 2024
@itowlson
Copy link
Collaborator

Note this will also require updating the conversion routines in the MySQL and Postgres factors.

@michelleN
Copy link
Collaborator

michelleN commented Oct 15, 2024

Note this will also require updating the conversion routines in the MySQL and Postgres factors.

@tyler-harpool - do you have bandwidth and/or interest in contributing the runtime bits for this @itowlson described in the next week or so (so that we can ensure it gets into Spin 3.0)? If you do, that's great. If not, we can make arrangements to have someone else contribute that bit. Just lmk! Thanks!

@tyler-harpool
Copy link
Author

Would love to handle this, but bandwidth is limited as I'm on holiday/PTO. I'm happy to punt as this would be a challenge on my side. Happy to do anything to assist.

@itowlson
Copy link
Collaborator

I'm closing this in favour of #2890 - @tyler-harpool is aware. Thank you again Tyler for getting this process under way!

@itowlson itowlson closed this Oct 22, 2024
@itowlson itowlson removed the spin-3.0 label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants