Run build steps on docs-only PRs so that all maintainers can merge them #2879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: itowlson <[email protected]>
fibonacci1729
approved these changes
Oct 9, 2024
Collaborator
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, PRs that only touch documents (e.g. SIPs, governance stuff, etc.) do not run the build workflow. This is great because it saves waiting for a build whose results can't have changed. Unfortunately, since we introduced required checks, it has meant that the required checks do not run on such PRs, so ordinary mortal maintainers can't merge them - we need to instead ping the administrators on high Olympus. So merging a docs PR now ends up being more effort and time, the problem that not running the build was meant to solve.
This PR proposes to resume running the build on these PRs.
Got a docs PR and want to merge it without waiting for the build? You can still do that by pinging an admin and getting them to bypass the checks, just like you have to do today. This PR just enables an alternative "mash that auto merge button and move on with your life" strategy.