Fix @ in URL path confusing the parser
#2906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itowlson
force-pushed
the
fix-at-in-url-path-host
branch
from
cff929c to
c2ec1de
Compare
rylev
approved these changes
Nov 5, 2024
Collaborator
rylev
left a comment
rylev
left a comment
There was a problem hiding this comment.
This seems like an improvement though we probably want to at some point throw away this code and use some sort of off-the-shelf URL parser.
lann
reviewed
Nov 5, 2024
Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
fix-at-in-url-path-host
branch
from
c2ec1de to
227aa8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2905.
I've added some tests to cover the behaviour. However, it will get confused in a different way if the username-password segment contains a forward slash (
ivan:sec/[email protected]). I'm not sure if that's a concern? @rylev you may know a better way to tackle this in which case feel free to close this!