Skip to content

If a component errors after starting the response, show that error #3041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

If a component errors after starting the response, show that error #3041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crates/trigger-http/src/wasi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use std::io::IsTerminal;
use std::net::SocketAddr;

use anyhow::{anyhow, Context, Result};
Expand Down Expand Up @@ -144,7 +145,11 @@ impl HttpExecutor for WasiHttpExecutor {
Ok(())
}
.map_err(|e: anyhow::Error| {
tracing::warn!("component error after response: {e:?}");
if std::io::stderr().is_terminal() {
tracing::error!("Component error after response started. The response may not be fully sent: {e:?}");
} else {
terminal::warn!("Component error after response started: {e:?}");
}
}),
);

Expand Down
Loading