Skip to content

Conversation

@fibonacci1729
Copy link
Collaborator

@fibonacci1729 fibonacci1729 commented Jul 8, 2025

Upgrade to the wasmtime v35.0.0 release branch; FWIW i'm fine leaving this sit while waiting for the crates.io release in approximately 2 weeks and switching then.

Upgrade to the v35.0.0 crates.io release of wasmtime

Notably this brings in a change to wasmtime to unforbid the te header which allows for gRPC clients to work in Spin components.

@fibonacci1729
Copy link
Collaborator Author

Waiting to rebase onto #3187

@fibonacci1729 fibonacci1729 force-pushed the bump-wasmtime branch 2 times, most recently from b8236d2 to d823f69 Compare July 9, 2025 15:47
@fibonacci1729 fibonacci1729 requested a review from itowlson July 9, 2025 16:18
Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Alex has approved it then I reckon I can't add much but I've added it anyway!

@lann
Copy link
Collaborator

lann commented Jul 9, 2025

FWIW i'm fine leaving this sit while waiting for the crates.io release in approximately 2 weeks and switching then.

Unless there is a compelling need for this before then let's do that. Should we move this PR back to draft in the meantime?

@fibonacci1729 fibonacci1729 marked this pull request as draft July 9, 2025 23:13
@fibonacci1729 fibonacci1729 changed the title Upgrade wasmtime to v35.0.0 release branch Upgrade wasmtime to v35.0.0 Jul 23, 2025
@fibonacci1729
Copy link
Collaborator Author

Now that wasmtime v35.0.0 is released to crates.io i am going to mark this ready for review.

@fibonacci1729 fibonacci1729 marked this pull request as ready for review July 23, 2025 19:45
@fibonacci1729 fibonacci1729 requested a review from itowlson July 23, 2025 19:46
@fibonacci1729 fibonacci1729 enabled auto-merge (squash) July 23, 2025 20:42
Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit: :shipit:

@fibonacci1729 fibonacci1729 merged commit 7417676 into spinframework:main Jul 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants