Initialise git repo in new app #3197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
approved these changes
Jul 14, 2025
crates/templates/src/git.rs
Outdated
| .stdout(Stdio::null()) | ||
| .stderr(Stdio::null()); | ||
|
|
||
| let status = cmd.status().await?; |
Collaborator
There was a problem hiding this comment.
nit: use of context would likely help here as the error message from the status call is likely to not be very helpful out of context.
crates/templates/src/run.rs
Outdated
| } | ||
| } | ||
|
|
||
| async fn initialise_git(&self) -> anyhow::Result<()> { |
Collaborator
There was a problem hiding this comment.
Nit:
Suggested change
| async fn initialise_git(&self) -> anyhow::Result<()> { | |
| async fn maybe_initialise_git(&self) -> anyhow::Result<()> { |
|
|
||
| let target_dir = self.generation_target_dir(); | ||
|
|
||
| let skip_initing_repo = git::is_in_git_repo(&target_dir).await.unwrap_or(true); |
Collaborator
There was a problem hiding this comment.
Should we warn if is_in_git_repo errors?
Collaborator
Author
There was a problem hiding this comment.
I would say not: we don't want to error on "git not installed," and other cases seem unlikely. We could trace or something if you feel strongly?
Contributor
|
@itowlson Rebasing on main will fix the CI errors now |
Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
git-init-in-new-app
branch
from
9e409e0 to
44ab8b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2580
This picks up on work done in #3155 by @iamrajiv. The core of that PR was fine, but unfortunately there were some unrelated blocking problems, and the PR has since gone inactive.