cli: Resolve clap/deprecated warnings #3228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lann Martin <[email protected]>
lann
commented
Aug 13, 2025
Comment on lines
-520
to
+509
| .get_possible_values() | ||
| .unwrap_or_default() | ||
| .get_value_parser() | ||
| .possible_values() | ||
| .into_iter() | ||
| .flatten() |
There was a problem hiding this comment.
This was the only substantive change in this file. The rest was rustfmt.
|
Could you say more about the motivation here? Deprecation doesn't seem like a substantial concern when we're intentionally staying on an old package version, so I'm not clear on the value of turning on the deprecation warnings. |
|
I've done this twice now on clap 4 upgrade attempts. 🤷 |
itowlson
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.