move the nginx HTTP2 bug workaround #3239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We remove the `host` header from the request if present because (some versions of?) nginx have a known bug such that they can't handle `host` headers in HTTP/2 requests. However, the request interceptor, if present, may have its own opinions about whether a `host` header should be set, and if it insists on setting one we should honor that. So I've moved the workaround to run _before_ the interceptor is run. Signed-off-by: Joel Dice <[email protected]>
dicej
force-pushed
the
move-nginx-workaround
branch
from
01cae01 to
5d43fa0
Compare
lann
approved these changes
Aug 20, 2025
radu-matei
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove the
hostheader from the request if present because (some versions of?) nginx have a known bug such that they can't handlehostheaders in HTTP/2 requests. However, the request interceptor, if present, may have its own opinions about whether ahostheader should be set, and if it insists on setting one we should honor that. So I've moved the workaround to run before the interceptor is run.