outbound-http: Improve test assertion logging

[lann]

I give up; here's some better logging instead.

Sneakily introduce assert_matches! and assert_not_matches! macros.

[itowlson]

"sneakily"

[lann]

"sneakily"

Did you notice?!

[itowlson]

Notice what?

[lann]

I have a hunch.

Some systems timeout instead of immediately failing requests to "discard prefix" IPv6 addrs (100::1). "I know!", I thought to myself, very cleverly, "I'll set a very low timeout and ignore timeouts for those tests!"

spin/crates/factor-outbound-http/tests/factor_test.rs

Line 141 in d1eb9ac

connect_timeout: Duration::from_millis(1),

"None of the tests actually touch the network, so short timeouts can't possibly cause problem!"

OR CAN THEY? (dunn dunn duuuuuunn)

spin/crates/factor-outbound-http/tests/factor_test.rs

Line 83 in d1eb9ac

let req = Request::get("http://localhost").body(Default::default())?;

"So what? That request gets rejected by the private IPs check before it gets sent."

BUT NOT BEFORE THE SYSTEM DNS RESOLVER GETS A WHACK AT IT! (gasp!)

spin/crates/factor-outbound-http/src/wasi.rs

Line 201 in d1eb9ac

let mut socket_addrs = tokio::net::lookup_host(&authority_str)

"But...but...it's just localhost! It still won't touch the network!" (desperation setting in)

THIS IS A HEAVILY LOADED GITHUB ACTIONS RUNNER! ONCE YOU'VE awaitED ANYTHING ALL YOUR PLANS ARE FOR NAUGHT!

Anyway its just a theory.