Skip to content

Allow non-kebab-case names in component ai_models #3259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

Allow non-kebab-case names in component ai_models #3259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions crates/manifest/src/compat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,6 @@ pub fn v1_to_v2_app(manifest: v1::AppManifestV1) -> Result<v2::AppManifest, Erro
.map(|(key, var)| Ok((id_from_string(key)?, var)))
.collect::<Result<_, Error>>()?;

let ai_models = component
.ai_models
.into_iter()
.map(id_from_string)
.collect::<Result<_, Error>>()?;
let allowed_http = convert_allowed_http_to_allowed_hosts(
&component.allowed_http_hosts,
component.allowed_outbound_hosts.is_none(),
Expand All @@ -71,7 +66,7 @@ pub fn v1_to_v2_app(manifest: v1::AppManifestV1) -> Result<v2::AppManifest, Erro
exclude_files: component.exclude_files,
key_value_stores: component.key_value_stores,
sqlite_databases: component.sqlite_databases,
ai_models,
ai_models: component.ai_models,
build: component.build,
tool: Default::default(),
allowed_outbound_hosts,
Expand Down
2 changes: 1 addition & 1 deletion crates/manifest/src/schema/v2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ pub struct Component {
/// Learn more: https://spinframework.dev/serverless-ai-api-guide#using-serverless-ai-from-applications
#[serde(default, skip_serializing_if = "Vec::is_empty")]
#[schemars(with = "Vec<json_schema::AIModel>")]
pub ai_models: Vec<KebabId>,
pub ai_models: Vec<String>,
/// The component build configuration.
///
/// Learn more: https://spinframework.dev/build
Expand Down
Loading