-
Notifications
You must be signed in to change notification settings - Fork 289
chore(examples): Update Spin Rust SDK and other dependencies #3276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): Update Spin Rust SDK and other dependencies #3276
Conversation
The Rust examples were all using Spin SDK 2.2.0, which targets a release candidate of WASIp2, not the final version. That means they only ran in Spin, not other WASI runtimes such as Wasmtime. This commit updates all applicable examples to the latest Spin SDK and changes the build target to `wasm32-wasip2` to directly build components. Signed-off-by: Till Schneidereit <[email protected]>
|
Closing #3258 in favor of this one. Also, would you mind updating gh workflows ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the gh workflows are updated and the comment about missing export! is addressed the tests should pass and this looks good to me!
Signed-off-by: Till Schneidereit <[email protected]>
|
This is great! With the samples compiling to If so, I'm happy to help - especially with the templates. For
|
Signed-off-by: Till Schneidereit <[email protected]>
I think updating the templates makes sense, yes. Brian's #3258 (which I had missed—apologies!) did that, though I think there were a few more parts of the templates that need updating. I'm less sure about |
Signed-off-by: Till Schneidereit <[email protected]>
Signed-off-by: Till Schneidereit <[email protected]>
The Rust examples were all using Spin SDK 2.2.0, which targets a release candidate of WASIp2, not the final version. That means they only ran in Spin, not other WASI runtimes such as Wasmtime.
This commit updates all applicable examples to the latest Spin SDK and changes the build target to
wasm32-wasip2to directly build components.Fixes #3275