factor-outbound-http: Update override_connect_host #3279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itowlson
approved these changes
Sep 18, 2025
Collaborator
Author
|
On further reflection I think the override should take a |
lann
force-pushed
the
fix-connect-override
branch
from
6dc6547 to
402cef5
Compare
Collaborator
Author
|
Sorry for the churn; it occurred to be that there was some ambiguity in what it means to override with an |
itowlson
approved these changes
Sep 18, 2025
radu-matei
approved these changes
Sep 19, 2025
- Rename to override_connect_addr - Change from String to SocketAddr - Fix bug in host resolution for ipv6 addresses Signed-off-by: Lann Martin <[email protected]>
lann
force-pushed
the
fix-connect-override
branch
from
402cef5 to
6ad9d0b
Compare
Collaborator
Author
|
Last update just adds commit signature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.