Update WIT world to WASI P3 RC #3295
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my best guess at what our world looks like with the Wasmtime 37 update. It's been a long time since we updated the core
platformWASI reference so I'm not super confident but I thinkwasi:cli/importsandwasi:http/handlerare all we need. I'm not quite sure if we need a 3.5 world that exports HTTP P2: apps targetingspin:[email protected]will be fine but I'm not sure if an app using the P2 handler signature could targetspin:[email protected](and work by inclusion of the 0.2.0 deps), or whether it would need to (since presumably such an app would be using P2 imports as well???). So @fibonacci1729 @dicej if you could take a critical look that would be super helpful... thanks!