Skip to content

Conversation

@fibonacci1729
Copy link
Collaborator

@fibonacci1729 fibonacci1729 commented Oct 13, 2025

Simple manual dispatch workflow for publishing the spin:up WIT package.

Draft for now until I amend the release notes.

Will follow up with separate PR amending the release notes once the first release is done.

@fibonacci1729 fibonacci1729 marked this pull request as ready for review October 13, 2025 20:59
@fibonacci1729 fibonacci1729 marked this pull request as draft October 13, 2025 20:59
Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM but wanted to double-check one thing (the other is a mere nit)

@itowlson
Copy link
Collaborator

Oh the other thing I couldn't remember from my previous testing (and now can't verify because nothing ever works) was if wkg packages arrived public or private. GHCR tends to default to private and I can't remember if wkg fixes that.

@fibonacci1729 fibonacci1729 marked this pull request as ready for review October 14, 2025 19:37
@fibonacci1729
Copy link
Collaborator Author

@itowlson good question; i'm not sure. I think it's something we can investigate once this lands and we try to publish the first package. cc/ @lann if you have thoughts on this.

@lann
Copy link
Collaborator

lann commented Oct 14, 2025

wkg just speaks generic OCI; it doesn't know anything about GitHub. If ghcr.io packages default to private then that's what will happen.

Edit: but I believe you only have to change the visibility for a package once.

@fibonacci1729 fibonacci1729 merged commit ceaed3a into spinframework:main Oct 14, 2025
17 checks passed
@fibonacci1729 fibonacci1729 deleted the publish-wits branch October 14, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants