This repository was archived by the owner on Dec 20, 2025. It is now read-only.
fix(google): Add retry and status polling logic#6380
Closed
mrusan wants to merge 1 commit intospinnaker:masterfrom
Closed
fix(google): Add retry and status polling logic#6380mrusan wants to merge 1 commit intospinnaker:masterfrom
mrusan wants to merge 1 commit intospinnaker:masterfrom
Conversation
… backend services chore(google): Fix regression bugs and improve tests chore(google): Handle all queryHealthCheck return types, fix deduplication chore(google): Correctly wait for any kind of LB chore(google): Add polling for backend services
d338342 to
1f60bc6
Compare
Contributor
Author
|
Closing in favor of spinnaker/spinnaker#7191 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses spinnaker/spinnaker#7170 similarly to #6379 but for the master branch code, which was refactored to Java.
The
enableAsyncOperationWaitflag was omitted for this PR, because part of the operations were already usinggoogleOperationPollercorrectly, and we're just making the behaviour consistent.Also covers a couple of regression bugs discovered during implementation and testing.