This repository was archived by the owner on Dec 20, 2025. It is now read-only.
feat(pipelineRef): conditionally load childExecutions when pipelineRef is enabled#10164
Closed
edgarulg wants to merge 6 commits intospinnaker:masterfrom
Closed
feat(pipelineRef): conditionally load childExecutions when pipelineRef is enabled#10164edgarulg wants to merge 6 commits intospinnaker:masterfrom
edgarulg wants to merge 6 commits intospinnaker:masterfrom
Conversation
edgarulg
requested review from
christosarvanitis,
dbyron-sf,
jasonmcintosh and
link108
danielGz
approved these changes
Feb 20, 2025
jasonmcintosh
approved these changes
Feb 20, 2025
Member
jasonmcintosh
left a comment
jasonmcintosh
left a comment
There was a problem hiding this comment.
I'm... still not totally comfortable on deck without tests, but.. this LOOKS like it'd work. I think the "tests" aspect is the only concern, but if rest of the approvers are good with UI stuff like this without tests, I'm good with it...
christosarvanitis
approved these changes
Feb 21, 2025
Member
christosarvanitis
left a comment
christosarvanitis
left a comment
There was a problem hiding this comment.
Thanks @edgarulg! This will keep the a consistent experience with not enabled the feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pipelineRef is enabled with the following changes: spinnaker/orca#4842
When click on the "View Pipeline Execution" in a execution with PipelineRef trigger Deck is not able to render parentExecution because it does not know how to handle a PipelineRefTrigger.
As part of this changes I defined a new feature flag in deck that conditionally retrieve parent executions when the user visit the SingleExecutionDetails component in the UI.
How to enable
Setting.jsneeds to define the pipelineRefEnabled flag.window.spinnakerSettings.feature.pipelineRefEnabled = true;