This repository was archived by the owner on Dec 20, 2025. It is now read-only.
fix(gcp): when regional eq true, show instances from all existing zones#10165
Closed
shlomodaari wants to merge 2 commits intospinnaker:masterfrom
shlomodaari:fix-gcp-zones-caching
Closed
fix(gcp): when regional eq true, show instances from all existing zones#10165shlomodaari wants to merge 2 commits intospinnaker:masterfrom shlomodaari:fix-gcp-zones-caching
shlomodaari wants to merge 2 commits intospinnaker:masterfrom
shlomodaari:fix-gcp-zones-caching
Conversation
Member
|
This fix is alongside with spinnaker/clouddriver#6351. Thanks @shlomodaari |
Member
|
@shlomodaari can you please remove the package-lock.json commit from this PR? |
Contributor
Author
|
@christosarvanitis I removed it, thank you for catching this! |
edgarulg
approved these changes
Mar 3, 2025
Contributor
edgarulg
left a comment
edgarulg
left a comment
There was a problem hiding this comment.
LGTM, thanks for helping with this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the fix: When regional=true, the system did not display all instances across all zones within the selected region.
After the fix: When regional=true, all instances from every zone within the selected region are correctly displayed.
When only one zone is selected, the behavior remains unchanged, and only the instances from that specific zone are shown.
This ensures accurate instance visibility for both regional and single-zone selections.