Skip to content
This repository was archived by the owner on Dec 20, 2025. It is now read-only.

Fix(gcp): fixing regional eq true instances type list, fixing test and adding test#10166

Merged
mergify[bot] merged 1 commit intospinnaker:masterfrom
shlomodaari:fix-zone-google
Mar 10, 2025
Merged

Fix(gcp): fixing regional eq true instances type list, fixing test and adding test#10166
mergify[bot] merged 1 commit intospinnaker:masterfrom
shlomodaari:fix-zone-google

Conversation

@shlomodaari
Copy link
Contributor

@shlomodaari shlomodaari commented Mar 5, 2025

When regional is true, it wasn't showing all the instances list, this should fix the issue, I also fix one of the tests and

@shlomodaari
Copy link
Contributor Author

shlomodaari commented Mar 5, 2025

image image

@spinnakerbot
Copy link
Contributor

spinnakerbot commented Mar 6, 2025

The following commits need their title changed:

  • bab2c31: fix(gcp) fixing accelerator_zones.spec test

  • 4d03c34: fix(gcp) fixing tests

  • 8d084d9: fix(gcp) fixing tests

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

edgarulg
edgarulg approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@edgarulg edgarulg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edgarulg edgarulg added ready to merge Reviewed and ready for merge backport-candidate Add to PRs to designate release branch patch candidates. labels Mar 10, 2025
@mergify mergify bot added the auto merged Merged automatically by a bot label Mar 10, 2025
@mergify mergify bot merged commit 2740ed5 into spinnaker:master Mar 10, 2025
4 checks passed
@edgarulg
Copy link
Contributor

edgarulg commented Mar 10, 2025

@mergify backport release-1.37.x

@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2025 •
edited
Loading

backport release-1.37.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Mar 10, 2025
@shlomodaari @mergify
fix(gcp): fixing existing test + adding one test and updating credent…
c673f66 
…ials.json (#10166)

(cherry picked from commit 2740ed5)
@mergify mergify bot mentioned this pull request Mar 10, 2025
Merged
mergify bot added a commit that referenced this pull request Mar 10, 2025
@mergify @shlomodaari
fix(gcp): fixing existing test + adding one test and updating credent…
b3f5263 
…ials.json (#10166) (#10167)

(cherry picked from commit 2740ed5)

Co-authored-by: Shlomo Daari <104773977+shlomodaari@users.noreply.github.com>
@shlomodaari
Copy link
Contributor Author

shlomodaari commented Mar 25, 2025

@edgarulg do you mind backporting this to 1.36.x? Is it possible to include this in the next 1.36.2 release?

@edgarulg
Copy link
Contributor

edgarulg commented Mar 25, 2025

@mergify backport release-1.36.x

@mergify
Copy link
Contributor

mergify bot commented Mar 25, 2025 •
edited
Loading

backport release-1.36.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Mar 25, 2025
@shlomodaari @mergify
fix(gcp): fixing existing test + adding one test and updating credent…
108e1bd 
…ials.json (#10166)

(cherry picked from commit 2740ed5)
@mergify mergify bot mentioned this pull request Mar 25, 2025
Merged
mergify bot added a commit that referenced this pull request Mar 25, 2025
@mergify @shlomodaari
fix(gcp): fixing existing test + adding one test and updating credent…
1b8f60a 
…ials.json (#10166) (#10169)

(cherry picked from commit 2740ed5)

Co-authored-by: Shlomo Daari <104773977+shlomodaari@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@edgarulg edgarulg edgarulg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto merged Merged automatically by a bot backport-candidate Add to PRs to designate release branch patch candidates. ready to merge Reviewed and ready for merge target-release/1.38

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shlomodaari @spinnakerbot @edgarulg