This repository was archived by the owner on Dec 20, 2025. It is now read-only.
fix(deck): Fix RunJob external logs when component is not mounted and interpolation is needed#10188
Closed
christosarvanitis wants to merge 1 commit intospinnaker:masterfrom
Closed
Conversation
… interpolation is needed
radu-dragon
approved these changes
Jul 22, 2025
| const { externalLink, podNamesProviders, location, account } = this.props; | ||
| // prefer links to external logging platforms | ||
| if (externalLink) { | ||
| if (externalLink && (!externalLink.includes('{{') || !isEmpty(manifest))) { |
Member
There was a problem hiding this comment.
I think we need a rewrite or rethink on this... too complicated of logic. I could see passing all of this down a bit and being a bit smarter on the checks internally.
ALSO ideally would have a test on these... spec test that checks the render logic maybe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deck is failing to render the external logs link when interpolation is needed but the async operation to Clouddriver to mount the manifest. This PR fixes this issue but keeps the ExternalLog link when interpolation is not needed