Adding filtering capabilities for bills

[shreyaNagunuri]

Closes #1155
Hi, after reviewing the comments found on PR #1308 I wanted to build off of that code and add more filtering capabilities as well as clean up the UI so that it doesn't look congested. This was a new feature as requested in the issue #1155 so that we can filter the bill screen.

This is my first time contributing to open source as a new developer so please let me know if I can improve in any way! Hope this helps!

Closed Filter:

Open:

[almet]

Hi and thanks for taking the time to open a pull request. Now the game is to continue discussing this and implement the missing bits :-)

I believe we're lacking tests for this. It might be discouraging and useless, but it's actually a nice way to ensure other people won't break your code by mistake, and probably also a way to find out bugs you might have introduced.

Let me know when you have added this, and I'll review everything altogether. Cheers!

[almet]

Hey, @shreyaNagunuri do you still want to work on this?

[Jojo144]

@shreyaNagunuri thanks for your contribution. I'm a bit late but I tested this PR and here are a few remarks:

• the panel should stay open when filtering bills
• it should be very clear that only a sample of the bills are displayed when filtering bills (maybe the previous point is enough)
• we should indicate how to unselect (with Ctrl) in the 'For Whom' field (maybe with a tool tip?)
• I think that we could add a button 'Reset filters' next to 'Apply filters'
• there is a bug with multiple pages (when there is lot of bills): going to another page reset the filters which does not seem the expected behavior
• I think that the 'Filter bills' button should be aligned with or below the 'Add new bill' button (instead of above)
• do we add a filter on the amount of the bill? (to search big bills for example)
• should we add a short sentence to explain the behavior of filtering? (maybe no, maybe just a tooltip on the filtering button)

I don't know if anyone wants to continue working on this PR. I think it would be a nice feature for I Hate Money. Me, I don't have the time for the moment. Maybe later...