430 add ability to search filter expenses#1374
Open
MilouH-TUE wants to merge 7 commits intospiral-project:mainfrom
Open
430 add ability to search filter expenses#1374MilouH-TUE wants to merge 7 commits intospiral-project:mainfrom
MilouH-TUE wants to merge 7 commits intospiral-project:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #430
I created this pull request in collaboration with @c5laungani . This merge request adds filter options for the bills list as requested in issue 430. We used the previous attempts for this issue as our starting point. Just before opening this pull request, we also observed that there was another issue (1155), that is a duplicate of the filtering issue. In a recent pull request for that issue, the feedback was to add tests. So in this pull request we tried to cover all feedback from previous attempts.
Screenshots:
Demo video:
https://github.com/user-attachments/assets/40465943-3819-4158-b642-b3fc5899c065
Please let us know if there's anything we should look into further!