uv migration by itsmeadarsh2008 · Pull Request #92 · spiraldb/ziggy-pydust-template

itsmeadarsh2008 · 2025-02-02T07:27:48Z

No description provided.

CLAassistant · 2025-02-02T07:27:54Z

All committers have signed the CLA.

jorenham

Thanks for this! I left a few cheeky comment; feel free to ignore them anyway you see fit 👌🏻.

_{Although it's a bit worrying that I'm the first to review this _{especially because I'm just a bypasser that has never contributed before that randomly started picking nits for no reason at all}}

jorenham · 2025-04-19T02:14:42Z

+      - name: 🐍 Set up Python
+        uses: actions/setup-python@v5


is this still needed?

just run uv python install

jorenham · 2025-04-19T02:15:08Z

-        id: cached-poetry-dependencies
-        uses: actions/cache@v4
+      - name: 📦 Install uv
+        uses: astral-sh/setup-uv@v4


In the meantime this setup-uv action has gotten a v5 release.

Also, by explicitly setting a python-version, you avoid having to use a .python-version file

Suggested change

uses: astral-sh/setup-uv@v4

uses: astral-sh/setup-uv@v5

with:

python-version: "3.12"

I think using a .python-version uses a standard way is a better way to declare compatible python version which I can refer to anywhere in the code, if I use it explicitly, I would have edit all the places where I referred to the incompatibility whenever I had to increment the python version.

Edit: Anyways, I am good with using v5

jorenham · 2025-04-19T02:22:59Z

+      - name: 🐍 Set up Python
+        uses: actions/setup-python@v5


There's no need for this; uv takes care of it all :)

(I can't suggest it as a change because of the interrupted diff unfortunately)

jorenham · 2025-04-19T02:29:51Z

-        id: cached-poetry-dependencies
-        uses: actions/cache@v4
+      - name: 📦 Install uv
+        uses: astral-sh/setup-uv@v4


see my comment above for the juicy deets:

Suggested change

uses: astral-sh/setup-uv@v4

uses: astral-sh/setup-uv@v4

with:

python-version: "3.12"

v5 and enable cache https://github.com/spiraldb/actions/blob/develop/.github/actions/setup-uv/action.yml#L21 maybe

jorenham · 2025-04-19T02:34:20Z

-      - name: Poetry Build
-        run: poetry build -v
-      - name: Publish package distributions to PyPI
+      - name: 🚀 Publish to PyPI


Maybe you're already aware, but uv publish is also a thing nowadays:
https://docs.astral.sh/uv/guides/package/#publishing-your-package

https://docs.astral.sh/uv/guides/package/#publishing-your-package
It requires tokens to authenticate with the PyPI server whereas the pypa action doesn't need that. I would prefer using loginless method

hm yea... that would complicate things

By loginless, do you mean trusted publishing? uv publish --trusted-publishing

Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>

jorenham · 2025-04-19T11:59:53Z

@delta003 or @0ax1, would you mind taking a look?

delta003 · 2025-04-28T11:03:52Z

-      - name: Poetry Build
-        run: poetry build -v
-      - name: Publish package distributions to PyPI
+      - name: 🚀 Publish to PyPI


By loginless, do you mean trusted publishing? uv publish --trusted-publishing

delta003 · 2025-04-28T11:10:18Z

+    "fibonacci",
+    "fibonacci/*.so",
+    "fibonacci/*.pyi",


Suggested change

"fibonacci",

"fibonacci/*.so",

"fibonacci/*.pyi",

"fibonacci/*.so",

"fibonacci/*.pyi",

Was there a reason you were adding fibonacci in both build targets?

No, I used https://github.com/mkniewallner/migrate-to-uv

So, it generated that way.

delta003 · 2025-04-28T11:13:45Z

-        id: cached-poetry-dependencies
-        uses: actions/cache@v4
+      - name: 📦 Install uv
+        uses: astral-sh/setup-uv@v4


v5 and enable cache https://github.com/spiraldb/actions/blob/develop/.github/actions/setup-uv/action.yml#L21 maybe

delta003 · 2025-04-28T11:14:30Z

+      - name: 🐍 Set up Python
+        uses: actions/setup-python@v5


just run uv python install

Co-authored-by: Marko Bakovic <delta003@users.noreply.github.com>

delta003 · 2025-04-28T11:21:49Z

-]

-[tool.poetry.build]
-script = "build.py"


I missed this the first time. Does hatchling backend runs it automatically? I can't seem to find that

I guess so.

Have you tried installing a built wheel (uv build in this project, uv add --wheel path to the built wheel), assuming there is no prebuilt .so file? Because when I build the wheel from your branch, I get what seems to be an empty wheel:

{ "abi": [ "none" ], "arch": [ "any" ], "buildver": null, "derived": { "dependencies": [], "description_in_body": true, "description_in_headers": false, "keyword_separator": null, "keywords": [], "modules": [ "fibonacci" ], "readme_renders": true }, "dist_info": { "metadata": { "author_email": "\"Fulcrum Inc.\" <hello@fulcrum.so>", "description": { "length": 601 }, "description_content_type": "text/markdown", "license_file": [ "LICENSE" ], "metadata_version": "2.4", "name": "ziggy-pydust-template", "requires_python": "~=3.11", "version": "0.1.0" }, "record": [ { "digests": { "sha256": "47DEQpj8HBSa-_TImW-5JCeuQeRkm5NMpJWZG3hSuFU" }, "path": "fibonacci/__init__.py", "size": 0 }, { "digests": { "sha256": "ZSJeVWewAuTCRB52GV1cJEXLqj41nuSOBNIDg8nM-_w" }, "path": "fibonacci/_lib.pyi", "size": 648 }, { "digests": { "sha256": "PHaZgv10bSvANoRvYv38PA6D5PBbz56aBsUM-i4zNuQ" }, "path": "ziggy_pydust_template-0.1.0.dist-info/METADATA", "size": 801 }, { "digests": { "sha256": "qtCwoSJWgHk21S1Kb4ihdzI2rlJ1ZKaIurTj_ngOhyQ" }, "path": "ziggy_pydust_template-0.1.0.dist-info/WHEEL", "size": 87 }, { "digests": { "sha256": "xx0jnfkXJvxRnG63LTGOxlggYnIysveWIZ6H3PNdCrQ" }, "path": "ziggy_pydust_template-0.1.0.dist-info/licenses/LICENSE", "size": 11357 }, { "digests": {}, "path": "ziggy_pydust_template-0.1.0.dist-info/RECORD", "size": null } ], "wheel": { "generator": "hatchling 1.27.0", "root_is_purelib": true, "tag": [ "py3-none-any" ], "wheel_version": "1.0" } }, "file": { "digests": { "md5": "06b6bc059b259aa3f251523a9b7db06d", "sha256": "3636d1b4a09d33430a3bb2548cc31f36227e4c62ef775772f7359f0be3591ab6" }, "size": 5992 }, "filename": "ziggy_pydust_template-0.1.0-py3-none-any.whl", "project": "ziggy_pydust_template", "pyver": [ "py3" ], "valid": true, "version": "0.1.0" }

migrated to uv

e80e08b

change poetry to uv in README

d45c5ea

jorenham reviewed Apr 19, 2025

View reviewed changes

itsmeadarsh2008 and others added 4 commits April 19, 2025 15:29

Update .github/workflows/ci.yml

54743c6

Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>

Update pyproject.toml

7993b4f

Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>

Update .github/workflows/ci.yml

5d78e95

Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>

Update .github/workflows/ci.yml

70c0206

Co-authored-by: Joren Hammudoglu <jhammudoglu@gmail.com>

delta003 reviewed Apr 28, 2025

View reviewed changes

itsmeadarsh2008 and others added 2 commits April 28, 2025 16:50

Update .python-version

b5724bc

Co-authored-by: Marko Bakovic <delta003@users.noreply.github.com>

Update pyproject.toml

d150b82

Co-authored-by: Marko Bakovic <delta003@users.noreply.github.com>

delta003 requested changes Apr 28, 2025

View reviewed changes

-        uses: astral-sh/setup-uv@v4
+        uses: astral-sh/setup-uv@v5
+        with:
+          python-version: "3.12"

Conversation

itsmeadarsh2008 commented Feb 2, 2025

Uh oh!

CLAassistant commented Feb 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jorenham left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

itsmeadarsh2008 Apr 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jorenham commented Apr 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Feb 2, 2025 •

edited

Loading

jorenham left a comment •

edited

Loading

itsmeadarsh2008 Apr 19, 2025 •

edited

Loading