Make the polyfill wait until after the Origin Trial as kicked in #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A starting point for discussion, if nothing else. Fixes #21... mostly.
The problem is that there isn't anywhere for us to insert our script that is after the Origin Trial is loaded but before any page script could be run. Testing shows that the script here is injected after scripts in the head but before scripts in the body.
This means that coming in after the Origin Trial gives the page chance to get a reference to the real versions of things like
VRFrameDataandnavigator.getVRDisplays().For me personally, I load my scripts in the body, and this change fixes things perfectly. For people who run their scripts in the head I'm not sure what happens.