Change how namespaced options are populated into the env#1287
Merged
Conversation
jrray
force-pushed
the
ns-opt-env-names
branch
from
408f6b2 to
049ea07
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
rydrman
approved these changes
Dec 3, 2025
Instead of `$SPK_OPT_pkgname.optname`, which is an invalid environment variable name, use `$SPK_PKG_pkgname_OPT_optname`. This format then resembles how other environment variables are named, such as `$SPK_PKG_pkgname_VERSION`. The old format is also still populated for backward compatibility and to allow projects to update to the new format. Signed-off-by: J Robert Ray <jrray@jrray.org>
jrray
force-pushed
the
ns-opt-env-names
branch
from
049ea07 to
97a805c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
$SPK_OPT_pkgname.optname, which is an invalid environment variable name, use$SPK_PKG_pkgname_OPT_optname. This format then resembles how other environment variables are named, such as$SPK_PKG_pkgname_VERSION.The old format is also still populated for backward compatibility and to allow projects to update to the new format.