Merged
Conversation
dcookspi
added
enhancement
dcookspi
force-pushed
the
remmove-migration-to-components-feature
branch
2 times, most recently
from
b9c0c9b to
cf1fa84
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jrray
approved these changes
Mar 25, 2026
Collaborator
jrray
left a comment
jrray
left a comment
There was a problem hiding this comment.
It'd be nice to add some supporting commentary in the PR description.
This feature behavior is creating friction for us in the development of the spk package index, and at SPI we never ended up leveraging this feature. Now that the "required" var mechanism exists, we believe it can be used to introduce breaking changes to packaging, like moving files that used to be available in the run component to a new component, and so the migration-to-components feature is not needed.
Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
jrray
force-pushed
the
remmove-migration-to-components-feature
branch
from
cf1fa84 to
2d4e4e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
migration-to-componentsfeature.