Let default splitting options be stored in database#366
Open
Uli-Z wants to merge 1 commit intospliit-app:mainfrom
Open
Let default splitting options be stored in database#366Uli-Z wants to merge 1 commit intospliit-app:mainfrom
Uli-Z wants to merge 1 commit intospliit-app:mainfrom
Conversation
Uli-Z
force-pushed
the
serverside-default-split-options
branch
3 times, most recently
from
28113ef to
811f6b1
Compare
This commit refactors the "default splitting options" feature to be stored on the server-side instead of in the client's localStorage. This provides a more consistent user experience, as the setting will now persist across different devices and browsers for all members of a group. The following changes were made: - The Group model in prisma.schema.prisma has been updated with a new defaultSplittingOptions JSON field. - A database migration has been added to apply this schema change. - The ExpenseForm component in expense-form.tsx has been updated to: - Fetch the default splitting options from the group object, which is populated from the database. - Use a new tRPC mutation, updateDefaultSplittingOptions, to persist the user's chosen default options back to the server. - All logic related to localStorage for this feature has been removed. Fixes spliit-app#327
Uli-Z
force-pushed
the
serverside-default-split-options
branch
from
811f6b1 to
375e0c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Issue #327
I corrected this behavior so that default splitting options are stored group-wide in the database.
Summary