Set split mode to EVENLY for reimbursements in ExpenseForm#367
Open
Uli-Z wants to merge 1 commit intospliit-app:mainfrom
Open
Set split mode to EVENLY for reimbursements in ExpenseForm#367Uli-Z wants to merge 1 commit intospliit-app:mainfrom
Uli-Z wants to merge 1 commit intospliit-app:mainfrom
Conversation
Uli-Z
force-pushed
the
bug-mark-as-paid
branch
from
1f3115d to
39ec54c
Compare
Contributor
Author
|
rebased the PR-branch to the current version. |
This commit fixes a significant usability issue where the "Mark as Paid" feature would behave incorrectly if the group had a default splitting option other than "Evenly". Previously, when a user set a default splitting method for a group (e.g., "Unevenly" or "By Shares"), this default was also being applied to reimbursements. A reimbursement, by its nature, is a simple transfer between two parties and should always be split evenly. Applying a different split mode was not a valid operation and resulted in a confusing and disruptive user experience, making it difficult to mark debts as paid. The fix is to update expense-form.tsx to ensure that when an expense is a reimbursement (isReimbursement: true), the splitMode is always hardcoded to 'EVENLY'. This change bypasses any group-level default splitting options for reimbursements, ensuring a smooth and intuitive workflow. Fixes spliit-app#365
Uli-Z
force-pushed
the
bug-mark-as-paid
branch
from
39ec54c to
e692842
Compare
Zufallsgenerat0r
pushed a commit
to Zufallsgenerat0r/spliit
that referenced
this pull request
Mar 11, 2026
Mark-as-paid reimbursements now always use EVENLY split mode instead of inheriting from stored default splitting options. Cherry-picked from spliit-app#367 by Uli-Z.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Issue #365
Updates expense-form.tsx so that Mark As Paid reimbursements always use the EVENLY split mode rather than the group’s saved defaults.