fix: Resolve 500 error on CSV export for group names with umlauts#377
Open
Uli-Z wants to merge 1 commit intospliit-app:mainfrom
Open
fix: Resolve 500 error on CSV export for group names with umlauts#377Uli-Z wants to merge 1 commit intospliit-app:mainfrom
Uli-Z wants to merge 1 commit intospliit-app:mainfrom
Conversation
5e42a3e to
3aef860
Compare
Contributor
Author
|
Just added an issue related to this bug: #458 ... and tested the solution against the current version. |
Previously, exporting groups with German umlauts in their names resulted in a 500 error due to incorrect handling of the header. This commit corrects the usage of the library to properly generate both ASCII (fallback) and UTF-8 (full) compatible filenames, ensuring successful CSV exports for all group names. Fixes spliit-app#458
3aef860 to
c4b28b0
Compare
Zufallsgenerat0r
pushed a commit
to Zufallsgenerat0r/spliit
that referenced
this pull request
Mar 11, 2026
Fixes 500 error when exporting CSV for groups with umlauts or other non-ASCII characters in the name. Uses content-disposition fallback parameter with ASCII-safe filename. Cherry-picked from spliit-app#377 by Uli-Z.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, exporting groups with German umlauts in their names resulted in a 500 error due to incorrect handling of the header. This commit corrects the usage of the library to properly generate both ASCII () and UTF-8 () compatible filenames, ensuring successful CSV exports for all group names.