Skip to content

Fix monkey patch of ActiveRecord::Base for records without primary key #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 9, 2025
Merged

Fix monkey patch of ActiveRecord::Base for records without primary key #282

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df8b680
Fix monkey patch of ActiveRecord::Base for records without primary keys
atranson-electra Mar 7, 2025
8bdeb33
Fix usage of nil primary key in tree builders related to active records
atranson-electra Mar 8, 2025
7d8a61e
Add tests to validate output for active records without primary keys
atranson-electra Mar 8, 2025
6fcdf98
Update changelog to highlight new fixes
atranson-electra Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
- Add official Rails 7.2 support. [#279](https://github.com/splitwise/super_diff/pull/279)
- Add official Rails 8.0 support. [#281](https://github.com/splitwise/super_diff/pull/281)

### Bug fixes

- Fix `attributes_for_super_diff` (in monkey patch of `ActiveRecord::Base`) which would fail for classes that don't have a primary key.
([#282](https://github.com/splitwise/super_diff/pull/282))

### Other changes

- Fix `logger` dependency issues in CI. [#277](https://github.com/splitwise/super_diff/pull/277)
Expand Down
2 changes: 1 addition & 1 deletion lib/super_diff/active_record/monkey_patches.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ def attributes_for_super_diff
id_attr = self.class.primary_key

(attributes.keys.sort - [id_attr]).reduce(
{ id_attr.to_sym => id }
id_attr.nil? ? {} : { id_attr.to_sym => id }
) { |hash, key| hash.merge(key.to_sym => attributes[key]) }
end
end
Expand Down