PAPP-36780-cert auth method#59
Open
NiemySpiewak-splunk wants to merge 3 commits intomsankowska/PSAAS-24763-porting_HTTP_to_SDKfrom
Open
PAPP-36780-cert auth method#59NiemySpiewak-splunk wants to merge 3 commits intomsankowska/PSAAS-24763-porting_HTTP_to_SDKfrom
NiemySpiewak-splunk wants to merge 3 commits intomsankowska/PSAAS-24763-porting_HTTP_to_SDKfrom
Conversation
NiemySpiewak-splunk
requested review from
mposluszny-splunk and
tapishj-splunk
src/request_maker.py
Outdated
Comment on lines
+111
to
+122
| parsed_body, raw_body = helpers.handle_various_response(response) | ||
| logger.info(f"Successfully processed data. Status: {response.status_code}") | ||
|
|
||
| return output_cls( | ||
| status_code=response.status_code, | ||
| location=full_url, | ||
| method=method, | ||
| parsed_response_body=parsed_body, | ||
| response_body=raw_body, | ||
| response_headers=str(dict(response.headers)), | ||
| ) | ||
|
|
There was a problem hiding this comment.
shouldn't this part be common for both _execute functions?
tapishj-splunk
force-pushed
the
msankowska/PSAAS-24763-porting_HTTP_to_SDK
branch
from
a7a9822 to
ee75fbf
Compare
Comment on lines
+133
to
+142
| if public_cert_data: | ||
| with tempfile.NamedTemporaryFile(delete=False) as f_pub: | ||
| f_pub.write(public_cert_data.encode("utf-8")) | ||
| public_cert_path = f_pub.name | ||
|
|
||
| if private_key_data: | ||
| with tempfile.NamedTemporaryFile(delete=False) as f_priv: | ||
| f_priv.write(private_key_data.encode("utf-8")) | ||
| private_key_path = f_priv.name | ||
|
|
Contributor
There was a problem hiding this comment.
I think cert based required both public and private keys to be not null. We should raise if both aren't a non empty string
Contributor
|
Need to fix merge conflicts and address 2 comments before merge. Ideally this should be a separate release from the main sdkfication major release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features
List any features you're adding to this app (e.g. new actions, parameters, auth methods, etc.)
Manual Documentation
Have you made any changes that should be documented in manual_readme_content.md?
The following changes require documentation in
manual_readme_content.md: