Feat/added additional validators for custom command arguments#1979
Open
Benni0 wants to merge 2 commits intosplunk:developfrom
Open
Feat/added additional validators for custom command arguments#1979Benni0 wants to merge 2 commits intosplunk:developfrom
Benni0 wants to merge 2 commits intosplunk:developfrom
Conversation
0800d46 to
c3944c2
Compare
…tion for custom command arguments.
c3944c2 to
1abdf45
Compare
This was referenced Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Summary
Adds support for the argument validators Set, Match, List, Map and Duration for custom commands.
Please review Pull Request #1977 first.
Changes
Updated the
schema.jsonto support the new argument validators with their required properties. Also changed the python command generator to generate the appropriate code.User experience
After this update the user has more possibilities to validate and parse custom command arguments:
Checklist
If an item doesn't apply to your changes, leave it unchecked.
Review
Tests
See the testing doc.
Demo/meeting:
Reviewers are encouraged to request meetings or demos if any part of the change is unclear