Skip to content

Feat/added additional validators for custom command arguments#1979

Open
Benni0 wants to merge 2 commits intosplunk:developfrom
Benni0:feat/add_argument_validators
Open

Feat/added additional validators for custom command arguments#1979
Benni0 wants to merge 2 commits intosplunk:developfrom
Benni0:feat/add_argument_validators

Conversation

@Benni0
Copy link
Copy Markdown
Contributor

@Benni0 Benni0 commented Feb 5, 2026

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Adds support for the argument validators Set, Match, List, Map and Duration for custom commands.
Please review Pull Request #1977 first.

Changes

Updated the schema.json to support the new argument validators with their required properties. Also changed the python command generator to generate the appropriate code.

User experience

After this update the user has more possibilities to validate and parse custom command arguments:

  • Set: allows the user to specify a list of valid argument values.
  • Match: allows the user to specify a regex pattern to validate the argument value.
  • List: allows the user to validate list argument values, which are parsed and passed as list.
  • Map: allows the user to specify a dictionary which automatically translates argument values.
  • Duration: allows the user to validate duration and timstamp argument values.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

@Benni0 Benni0 requested review from a team as code owners February 5, 2026 11:44
@Benni0 Benni0 marked this pull request as draft February 5, 2026 12:24
@Benni0 Benni0 force-pushed the feat/add_argument_validators branch 6 times, most recently from 0800d46 to c3944c2 Compare February 5, 2026 13:43
@Benni0 Benni0 force-pushed the feat/add_argument_validators branch from c3944c2 to 1abdf45 Compare February 5, 2026 13:55
@Benni0 Benni0 marked this pull request as ready for review February 5, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant