Skip to content

fix: ensure scheduled runs always use latest splunk version #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poojpat2 merged 15 commits into from
Feb 11, 2026
Merged

fix: ensure scheduled runs always use latest splunk version #459

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ec895d4
changes made for scheduledruns
poojpat2 Jan 29, 2026
e744612
Add workflow scheduler runs
poojpat2 Jan 30, 2026
f8138a5
Added workflow scheduler runs
poojpat2 Jan 30, 2026
acb2b8b
changes made for scheduled
poojpat2 Jan 30, 2026
729eb0b
changes done for scheduled
poojpat2 Feb 3, 2026
281a30b
changes did for scheduled workflow
poojpat2 Feb 3, 2026
2d95cc8
changes did for workflow
poojpat2 Feb 3, 2026
d47313c
Added fix workflow scheduler runs
poojpat2 Feb 4, 2026
b8988e7
Added fix for btool timeout
poojpat2 Feb 5, 2026
4ddbfe5
Added fix for btool
poojpat2 Feb 5, 2026
583d119
Added fix
poojpat2 Feb 5, 2026
829d381
changes done for workflow
poojpat2 Feb 6, 2026
d1a040c
changes did for workflow1
poojpat2 Feb 6, 2026
4f5c3ca
changes did for workflow2
poojpat2 Feb 6, 2026
0b70226
removed redundant condition
poojpat2 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions .github/workflows/reusable-build-test-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,15 +373,24 @@ jobs:
- id: determine_splunk
env:
wfe_run_on_splunk_latest: ${{ inputs.wfe-run-on-splunk-latest }}
Copy link
Contributor

@mkolasinski-splunk mkolasinski-splunk Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is removed, then input inputs.wfe-run-on-splunk-latest is never referenced in the workflow, meaning it's reduntant.

Copy link
Contributor

@mkolasinski-splunk mkolasinski-splunk Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example run supposed to run on all Splunk versions supported: https://github.com/splunk/test-addonfactory-repo/actions/runs/21628063395

https://github.com/splunk/test-addonfactory-repo/blob/refs/heads/mkolasinski-splunk-patch-3/.github/workflows/build-test-release.yml#L29

run: |
if [[ "$wfe_run_on_splunk_latest" == "" ]]; then
Copy link
Contributor

@mbruzda-splunk mbruzda-splunk Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now wfe_run_on_splunk_latest is set to false at the top of the workflow, so this condition never passes

Copy link
Contributor Author

@poojpat2 poojpat2 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, the previous logic never recalculated because the input defaulted to false, which is why the condition was refactored to explicitly evaluate branch and event instead of relying on an empty value.

wfe_run_on_splunk_latest="${{ github.event_name == 'schedule' || !((github.base_ref == 'main' || github.ref_name == 'main') || ((github.base_ref == 'develop' || github.ref_name == 'develop') && github.event_name == 'push')) }}"
Copy link
Contributor

@mbruzda-splunk mbruzda-splunk Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the variable is never empty, this block never runs and the value is never recalculated based on the branch or event. That means the logic below is effectively skipped every time

Copy link
Contributor Author

@poojpat2 poojpat2 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this was the core issue, and the fix ensures the value is always recomputed based on schedule, input, branch, and event as required by Jira.

Copy link
Contributor

@mbruzda-splunk mbruzda-splunk Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think wfe_run_on_splunk_latest would be calculated correctly if we actually reached this code block?

Copy link
Contributor Author

@poojpat2 poojpat2 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is old commit which is removed this empty input code in the latest finalized commit.

run: |
if [[ "${{ github.event_name }}" == "schedule" ]]; then
wfe_run_on_splunk_latest="true"

else
if [[ "${{ github.base_ref }}" == "main" || "${{ github.ref_name }}" == "main" ]] || \
[[ "${{ github.ref_name }}" == "develop" && "${{ github.event_name }}" == "push" ]]; then
wfe_run_on_splunk_latest="false"
else
wfe_run_on_splunk_latest="true"
fi
fi
if [[ "$wfe_run_on_splunk_latest" == "true" ]]; then
echo "matrixSplunk=${{ toJson(steps.matrix.outputs.latestSplunk) }}" >> "$GITHUB_OUTPUT"
else
echo "matrixSplunk=${{toJson(steps.matrix.outputs.supportedSplunk) }}" >> "$GITHUB_OUTPUT"
echo "matrixSplunk=${{ toJson(steps.matrix.outputs.supportedSplunk) }}" >> "$GITHUB_OUTPUT"
fi

- name: job summary
run: |
splunk_version_list=$(echo '${{ steps.determine_splunk.outputs.matrixSplunk }}' | jq -r '.[].version')
Expand Down
Loading