-
Notifications
You must be signed in to change notification settings - Fork 127
mirror attack_data archive to s3 #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
push compressed attack data archive to S3. Remove txt file that should not be in the root of the repo.
s3 puts
need to do so
data is pushed to master (default branch)
Contributor
Author
|
Note this PR adds cleanup and features relevant to getting the following PR working |
and the build date in the cache file
filename
ljstella
approved these changes
May 2, 2025
Contributor
ljstella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft of new workflow to
push compressed attack
data archive to S3. Remove txt
file that should not be in
the root of the repo.
This is useful in that it speeds up testing, significantly, and avoids error
where media.githubusercontent returns an error when trying to download
associated attack data.
Note for this to work, we will have to uncomment parts of the workflow
as well as add some secrets to the repository with respect to S3.